[ 
https://issues.apache.org/jira/browse/FLINK-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587344#comment-16587344
 ] 

ASF GitHub Bot commented on FLINK-10042:
----------------------------------------

StefanRRichter commented on a change in pull request #6556: FLINK-10042][state] 
Extract snapshot algorithms from inner classes of RocksDBKeyedStateBackend into 
full classes
URL: https://github.com/apache/flink/pull/6556#discussion_r211583117
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ##########
 @@ -230,7 +210,7 @@
         * Information about the k/v states as we create them. This is used to 
retrieve the
         * column family that is used for a state and also for sanity checks 
when restoring.
         */
-       private final Map<String, Tuple2<ColumnFamilyHandle, 
RegisteredStateMetaInfoBase>> kvStateInformation;
+       private final LinkedHashMap<String, Tuple2<ColumnFamilyHandle, 
RegisteredStateMetaInfoBase>> kvStateInformation;
 
 Review comment:
   Just to make it a bit more explicit and avoid that somebody changes the 
implementation because the order is important. Will add also to the comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract snapshot algorithms from inner classes into full classes
> ----------------------------------------------------------------
>
>                 Key: FLINK-10042
>                 URL: https://issues.apache.org/jira/browse/FLINK-10042
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to