[
https://issues.apache.org/jira/browse/FLINK-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587302#comment-16587302
]
ASF GitHub Bot commented on FLINK-9962:
---------------------------------------
kl0u commented on a change in pull request #6492: [FLINK-9962] [FS connector]
allow users to specify TimeZone in DateTimeBucketer
URL: https://github.com/apache/flink/pull/6492#discussion_r211568018
##########
File path:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/DateTimeBucketer.java
##########
@@ -38,8 +39,8 @@
* is determined based on the current system time and the user provided format
string.
*
*
- * <p>{@link SimpleDateFormat} is used to derive a date string from the
current system time and
- * the date format string. The default format string is {@code
"yyyy-MM-dd--HH"} so the rolling
+ * <p>{@link DateTimeFormatter} is used to derive a date string from the
current system time and
Review comment:
Same comments as for the `DateTimeBucketAssigner`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> allow users to specify TimeZone in DateTimeBucketer
> ---------------------------------------------------
>
> Key: FLINK-9962
> URL: https://issues.apache.org/jira/browse/FLINK-9962
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Affects Versions: 1.5.1, 1.6.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Currently {{DateTimeBucketer}} will return a bucket path by using local
> timezone. We should add a {{timezone}} constructor param to allow users to
> specify a timezone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
