[
https://issues.apache.org/jira/browse/FLINK-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582141#comment-16582141
]
ASF GitHub Bot commented on FLINK-9116:
---------------------------------------
StefanRRichter commented on a change in pull request #6558: [FLINK-9116]
Introduce getAll and removeAll for MapState
URL: https://github.com/apache/flink/pull/6558#discussion_r210508829
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java
##########
@@ -91,6 +93,22 @@ public UV get(UK userKey) {
return userMap.get(userKey);
}
+ @Override
+ public Map<UK, UV> getAll(Collection<UK> keys) {
+
+ Map<UK, UV> userMap = stateTable.get(currentNamespace);
Review comment:
I feel like by now we could really introduce a helper method `getUserMap()
{stateTable.get(currentNamespace);}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Introduce getAll and removeAll for MapState
> -------------------------------------------
>
> Key: FLINK-9116
> URL: https://issues.apache.org/jira/browse/FLINK-9116
> Project: Flink
> Issue Type: New Feature
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> We have supported {{putAll(List)}} in {{MapState}}, I think we should also
> support {{getAll(Iterable)}} and {{removeAll(Iterable)}} in {{MapState}}, it
> can be convenient in some scenario.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
