yanghua commented on issue #6542: [FLINK-6437][History Server] Move history 
server configuration to a separate file
URL: https://github.com/apache/flink/pull/6542#issuecomment-412433339
 
 
   @zentol I have read the comments of this issue (no one explicitly objected), 
I think if you don't need to do it, then we should clearly mark it on JIRA. 
Also in the PR description, I explained that it passed my local test. I 
originally wanted to write a test case. This PR change is mainly for 
`GlobalConfiguration`. I have already seen it. Flink didn't test 
`flink-conf.yaml` before, and it doesn't seem to provide the infrastructure for 
this kind of test. The configuration-related tests are all about creating a 
Configuration object yourself and then setting values for it.
   
   If Flink's original code already contains tests for this configuration file 
path, I can write tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to