[ https://issues.apache.org/jira/browse/FLINK-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571740#comment-16571740 ]
ASF GitHub Bot commented on FLINK-9933: --------------------------------------- dawidwys commented on issue #6444: [FLINK-9933] Simplify taskmanager memory default values URL: https://github.com/apache/flink/pull/6444#issuecomment-411073638 Thanks for the PR @yanghua . Let's do the same for `MEMORY_SEGMENT_SIZE`. I would be in favor of removing space between number and unit e.g. `64 mb` -> `64mb`. Also would unify the version of unit we use Either use (`gb` and `mb`) or (`m` and `g`) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify taskmanager memory default values > ------------------------------------------ > > Key: FLINK-9933 > URL: https://issues.apache.org/jira/browse/FLINK-9933 > Project: Flink > Issue Type: Improvement > Components: Documentation > Affects Versions: 1.6.0 > Reporter: Chesnay Schepler > Assignee: vinoyang > Priority: Minor > Labels: pull-request-available > > The default value for {{NETWORK_BUFFERS_MEMORY_MIN}} is currently defined is > {{String.valueOf(64L << 20)}}, which in the documentation is represented as > {{"67108864"}}. > Now that we have the {{MemorySize}} utility we can change the default to > {{"64 mb"}}. > The same applies to {{NETWORK_BUFFERS_MEMORY_MAX}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)