[ 
https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571385#comment-16571385
 ] 

ASF GitHub Bot commented on FLINK-6847:
---------------------------------------

twalthr commented on a change in pull request #6282: [FLINK-6847][FLINK-6813] 
[table] TimestampDiff table api and sql support
URL: https://github.com/apache/flink/pull/6282#discussion_r208151120
 
 

 ##########
 File path: docs/dev/table/sql.md
 ##########
 @@ -2247,6 +2247,17 @@ TIMESTAMPADD(unit, interval, timestamp)
       </td>
     </tr>
 
+    <tr>
+      <td>
+        {% highlight text %}
+TIMESTAMPDIFF(unit, timestamp1, timestamp2)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the (signed) number of timeUnit intervals between 
timestamp1 and timestamp2. The unit for the interval is given by the unit 
argument, which should be one of the following values: <code>SECOND</code>, 
<code>MINUTE</code>, <code>HOUR</code>, <code>DAY</code>, <code>WEEK</code>, 
<code>MONTH</code>, <code>QUARTER</code>, or <code>YEAR</code>. E.g. 
<code>TIMESTAMPDIFF(DAY, DATE '2003-01-02', DATE '2003-01-03')</code> leads to 
<code>1</code>.</p>
 
 Review comment:
   Could you create a table of time intervals units and time point units? We 
could move this to a subsection and reference it for all functions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add TIMESTAMPDIFF supported in TableAPI
> ---------------------------------------
>
>                 Key: FLINK-6847
>                 URL: https://issues.apache.org/jira/browse/FLINK-6847
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Priority: Major
>              Labels: pull-request-available, starter
>
> see FLINK-6813



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to