[ 
https://issues.apache.org/jira/browse/FLINK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571365#comment-16571365
 ] 

Fabian Hueske commented on FLINK-5315:
--------------------------------------

Hi [~walterddr] and [~hequn8128], Thanks for the discussion!

I agree with [~hequn8128]. {{Table.distinct}} is different from 
{{agg.distinct('a, 'b)}} or {{'a.agg.distinct}}. 
In fact, {{Table.distinct}} is a separate operator and not related to 
{{Table.select()}}. 

I would leave {{Table.distinct}} as it is and stick to this proposal

{code}
'a.count.distinct
myUdagg.distinct('a)
multiParamAgg.distinct('a, 'b)
{code}

> Support distinct aggregations in table api
> ------------------------------------------
>
>                 Key: FLINK-5315
>                 URL: https://issues.apache.org/jira/browse/FLINK-5315
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kurt Young
>            Assignee: Rong Rong
>            Priority: Major
>
> Support distinct aggregations in Table API in the following format:
> For Expressions:
> {code:scala}
> 'a.count.distinct // Expressions distinct modifier
> {code}
> For User-defined Function:
> {code:scala}
> singleArgUdaggFunc.distinct('a) // FunctionCall distinct modifier
> multiArgUdaggFunc.distinct('a, 'b) // FunctionCall distinct modifier
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to