[
https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569834#comment-16569834
]
ASF GitHub Bot commented on FLINK-9134:
---------------------------------------
twalthr commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207798413
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/GroupWindowTest.scala
##########
@@ -161,7 +161,7 @@ class GroupWindowTest extends TableTestBase {
"rowtime('w$) AS w$rowtime",
"proctime('w$) AS w$proctime")
),
- term("select", "EXPR$0", "DATETIME_PLUS(w$end, 60000) AS EXPR$1")
+ term("select", "EXPR$0", "+(w$end, 60000) AS EXPR$1")
Review comment:
Thanks for the research. @suez1224 if you find time, you could discuss this
in the Calcite community again. I find it a bit confusing to have the same same
string for different SQL operators. But it is not a blocker for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite dependency to 1.17
> ---------------------------------
>
> Key: FLINK-9134
> URL: https://issues.apache.org/jira/browse/FLINK-9134
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> This is an umbrella issue for tasks that need to be performed when upgrading
> to Calcite 1.17 once it is released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
