[
https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569162#comment-16569162
]
ASF GitHub Bot commented on FLINK-10056:
----------------------------------------
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add
JobMasterTest#testRequestNextInputSplit
URL: https://github.com/apache/flink/pull/6490#discussion_r207707125
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
##########
@@ -118,7 +118,9 @@ public static void waitUntilJobStatus(ExecutionGraph eg,
JobStatus status, long
}
if (System.nanoTime() >= deadline) {
- throw new TimeoutException("The job did not reach
status " + status + " in time. Current status is " + eg.getState() + '.');
+ throw new TimeoutException(
+ "The job did not reach status " + status + " in
time. " +
+ "Current status is " + eg.getState() + '.');
Review comment:
please use unified `""` not `''`. what's more, use string format looks
better to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add testRequestNextInputSplit
> -----------------------------
>
> Key: FLINK-10056
> URL: https://issues.apache.org/jira/browse/FLINK-10056
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, Tests
> Affects Versions: 1.5.0
> Reporter: 陈梓立
> Assignee: 陈梓立
> Priority: Major
> Labels: pull-request-available
>
> Add testRequestNextInputSplit to make sure JobMaster#requestNextInputSplit
> works as expected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
