yanghua commented on a change in pull request #6470: [FLINK-10006][network]
improve logging in BarrierBuffer: prepend owning task name
URL: https://github.com/apache/flink/pull/6470#discussion_r206931425
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -432,7 +437,8 @@ public void releaseAllResources() throws IOException {
inputChannel.releaseAllResources();
}
catch (IOException e) {
- LOG.warn("Error during
release of channel resources: " + e.getMessage(), e);
+ LOG.warn("{}: Error
during release of channel resources: " + e.getMessage(),
Review comment:
use placeholder ({}) for `e.getMessage()` looks better to me~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
