zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206916150
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/utils/SystemResourcesMetricsInitializer.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskexecutor.utils; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.metrics.Gauge; +import org.apache.flink.metrics.MetricGroup; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import oshi.SystemInfo; +import oshi.hardware.GlobalMemory; +import oshi.hardware.HardwareAbstractionLayer; + +/** + * Utility class ot initialize system resources metrics. + */ +public class SystemResourcesMetricsInitializer { + private static final Logger LOG = LoggerFactory.getLogger(SystemResourcesMetricsInitializer.class); + + public static void instantiateSystemMetrics(MetricGroup metricGroup, Time logInterval) { + try { + MetricGroup system = metricGroup.addGroup("System"); + + SystemResourcesCounter systemResourcesCounter = new SystemResourcesCounter(logInterval); + systemResourcesCounter.start(); + + SystemInfo systemInfo = new SystemInfo(); + HardwareAbstractionLayer hardwareAbstractionLayer = systemInfo.getHardware(); + + instantiateMemoryMetrics(system.addGroup("Memory"), hardwareAbstractionLayer.getMemory()); + instantiateSwapMetrics(system.addGroup("Swap"), hardwareAbstractionLayer.getMemory()); + instantiateCPUMetrics(system.addGroup("CPU"), systemResourcesCounter); + instantiateNetworkMetrics(system.addGroup("Network"), systemResourcesCounter); + } + catch (NoClassDefFoundError ex) { + LOG.warn( + "Failed to initialize system resources metrics because of missing classes definitions." + Review comment: "system resource metrics" "missing class definitions" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
