twalthr commented on a change in pull request #6453: [FLINK-9874][E2E Tests]
Fix set_ssl_conf for macOS
URL: https://github.com/apache/flink/pull/6453#discussion_r206811377
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -154,12 +175,15 @@ function set_conf_ssl {
rm -rf "${TEST_DATA_DIR}/ssl"
fi
mkdir -p "${TEST_DATA_DIR}/ssl"
+
NODENAME=`hostname -f`
SANSTRING="dns:${NODENAME}"
- for NODEIP in `hostname -I | cut -d' ' -f1` ; do
+ for NODEIP in $(get_node_ip) ; do
Review comment:
Why did you remove the additional `| cut -d' ' -f1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
