tzulitai commented on a change in pull request #6440: [FLINK-9979] [table] Support a FlinkKafkaPartitioner for Kafka table sink factory URL: https://github.com/apache/flink/pull/6440#discussion_r206767510
########## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08TableSink.java ########## @@ -51,11 +52,11 @@ public Kafka08TableSink( String topic, Properties properties, SerializationSchema<Row> serializationSchema, - FlinkKafkaPartitioner<Row> partitioner) { + Optional<FlinkKafkaPartitioner<Row>> partitioner) { return new FlinkKafkaProducer08<>( topic, serializationSchema, properties, - partitioner); + partitioner.orElse(null)); Review comment: Same question here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services