[
https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563658#comment-16563658
]
ASF GitHub Bot commented on FLINK-9936:
---------------------------------------
GJL commented on a change in pull request #6451: [FLINK-9936] Resource manager
connect to mesos after leadership granted. .
URL: https://github.com/apache/flink/pull/6451#discussion_r206522513
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -221,10 +221,14 @@ protected ActorRef
createReconciliationCoordinator(SchedulerDriver schedulerDriv
//
------------------------------------------------------------------------
/**
- * Starts the Mesos-specifics.
+ * Do nothing and all work has been moved to on leadership granted
callback.
*/
@Override
protected void initialize() throws ResourceManagerException {
+ }
+
+ @Override
+ protected void onLeaderShipGranted() throws Exception {
Review comment:
We are re-creating the supporting actors without shutting them down. This
should result in memory leaks everytime the instance wins the leader election.
It is also not very nice that we occupy the main thread of the actor with
blocking IO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Mesos resource manager unable to connect to master after failover
> -----------------------------------------------------------------
>
> Key: FLINK-9936
> URL: https://issues.apache.org/jira/browse/FLINK-9936
> Project: Flink
> Issue Type: Bug
> Components: Mesos, Scheduler
> Affects Versions: 1.5.0, 1.5.1, 1.6.0
> Reporter: Renjie Liu
> Assignee: Gary Yao
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.5.3, 1.6.0
>
>
> When deployed in mesos session cluster mode, the connector monitor keeps
> reporting unable to connect to mesos after restart. In fact, scheduler driver
> already connected to mesos master, but when the connected message is lost.
> This is because leadership is not granted yet and fence id is not set, the
> rpc service ignores the connected message. So we should connect to mesos
> master after leadership is granted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
