[
https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559566#comment-16559566
]
ASF GitHub Bot commented on FLINK-9576:
---------------------------------------
zentol commented on a change in pull request #6268: [FLINK-9576] Fixed
documentation for contiguity within looping pattern.
URL: https://github.com/apache/flink/pull/6268#discussion_r205737666
##########
File path: docs/dev/libs/cep.md
##########
@@ -250,21 +250,10 @@ For a pattern named `start`, the following are valid
quantifiers:
#### Conditions
-At every pattern, and to go from one pattern to the next, you can specify
additional **conditions**.
-You can relate these conditions to:
-
- 1. A [property of the incoming event](#conditions-on-properties), e.g. its
value should be larger than 5,
- or larger than the average value of the previously accepted events.
-
- 2. The [contiguity of the matching events](#conditions-on-contiguity), e.g.
detect pattern `a,b,c` without
- non-matching events between any matching ones.
-
-The latter refers to "looping" patterns, *i.e.* patterns that can accept more
than one event, e.g. the `b+` in `a b+ c`,
-which searches for one or more `b`'s.
-
-##### Conditions on Properties
-
-You can specify conditions on the event properties via the `pattern.where()`,
`pattern.or()` or the `pattern.until()` method. These can be either
`IterativeCondition`s or `SimpleCondition`s.
+For every pattern you can specify a condition that incoming event has to met
in order to be "accepted" into the pattern e.g. its value should be larger than
5,
Review comment:
typo: that an incoming event
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Wrong contiguity documentation
> ------------------------------
>
> Key: FLINK-9576
> URL: https://issues.apache.org/jira/browse/FLINK-9576
> Project: Flink
> Issue Type: Bug
> Components: CEP, Documentation
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> Example for the contiguity is first of all wrong, and second of all
> misleading:
>
> {code:java}
> To illustrate the above with an example, a pattern sequence "a+ b" (one or
> more "a"’s followed by a "b") with input "a1", "c", "a2", "b" will have the
> following results:
> Strict Contiguity: {a2 b} – the "c" after "a1" causes "a1" to be discarded.
> Relaxed Contiguity: {a1 b} and {a1 a2 b} – "c" is ignored.
> Non-Deterministic Relaxed Contiguity: {a1 b}, {a2 b}, and {a1 a2 b}.
> For looping patterns (e.g. oneOrMore() and times()) the default is relaxed
> contiguity. If you want strict contiguity, you have to explicitly specify it
> by using the consecutive() call, and if you want non-deterministic relaxed
> contiguity you can use the allowCombinations() call.
> {code}
>
> Results for the relaxed contiguity are wrong plus they do not clearly
> explains the internal contiguity of kleene closure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
