GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6403
    [FLINK-9934] [table] Fix invalid field mapping by Kafka table source factory

    ## What is the purpose of the change
    
    According to the `DefinedFieldMapping` interface the field mapping can also 
contain the input fields. However, the Kafka table source factory was calling 
`SchemaValidator#deriveFieldMapping` with its own schema instead of the the 
input type. 
    
    
    ## Brief change log
    
    - Replace schema with type in `SchemaValidator#deriveFieldMapping` to avoid 
confusion
    - Adapted tests
    
    ## Verifying this change
    
    The `KafkaTableSourceSinkFactoryTestBase` has been extended.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-9934

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6403
    
----
commit 6f69a241ae555398580857e8b1aca5522a284ac4
Author: Timo Walther <twalthr@...>
Date:   2018-07-24T09:40:36Z

    [FLINK-9934] [table] Fix invalid field mapping by Kafka table source factory

----


---

Reply via email to