[ 
https://issues.apache.org/jira/browse/FLINK-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549712#comment-16549712
 ] 

ASF GitHub Bot commented on FLINK-9435:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6115


> Remove per-key selection Tuple instantiation via reflection in 
> ComparableKeySelector and ArrayKeySelector
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-9435
>                 URL: https://issues.apache.org/jira/browse/FLINK-9435
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.4.0, 1.5.0, 1.4.1, 1.4.2, 
> 1.6.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> Inside {{KeySelectorUtil}}, every {{ComparableKeySelector#getKey()}} call 
> currently creates a new tuple from 
> {{Tuple.getTupleClass(keyLength).newInstance();}} which seems expensive. 
> Instead, we could get a template tuple and use {{Tuple#copy()}} which copies 
> the right sub-class in a more optimal way.
> Similarly, {{ArrayKeySelector}} instantiates new {{Tuple}} instances via 
> reflection which can be changed the same way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to