[ https://issues.apache.org/jira/browse/FLINK-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549183#comment-16549183 ]
ASF GitHub Bot commented on FLINK-9888: --------------------------------------- Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6362 +1 > Remove unsafe defaults from release scripts > ------------------------------------------- > > Key: FLINK-9888 > URL: https://issues.apache.org/jira/browse/FLINK-9888 > Project: Flink > Issue Type: Bug > Components: Release System > Affects Versions: 1.4.0, 1.5.0, 1.6.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Priority: Major > Labels: pull-request-available > > Several variables in the release scripts have unsafe defaults, like these > from {{create_release_branch.sh}}: > {code} > OLD_VERSION=${OLD_VERSION:-1.2-SNAPSHOT} > NEW_VERSION=${NEW_VERSION:-1.3-SNAPSHOT} > {code} > We should not allow the script to run successfully without these being > explicitly set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)