Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6363#discussion_r203662639
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java
 ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.network.netty;
    +
    +import org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector;
    +import 
org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetectorFactory;
    +
    +import org.junit.rules.ExternalResource;
    +
    +import javax.annotation.concurrent.GuardedBy;
    +
    +import static org.junit.Assert.fail;
    +
    +/**
    + * JUnit resource to fail with an assertion when Netty detects a resource 
leak (only with
    + * <tt>ERROR</tt> logging enabled for
    + * 
<tt>org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector</tt>).
    --- End diff --
    
    Would it be possible to check for this condition by doing something like 
this in `@Before`?
    
    ```
    
Assert.assertTrue(LoggerFactory.getLogger(org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector.class).isErrorEnabled());
    ```
    ```


---

Reply via email to