Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6284#discussion_r202087570
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
 ---
    @@ -250,6 +250,10 @@ public static Configuration 
generateTaskManagerConfiguration(
                        cfg.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 
numSlots);
                }
     
    +           if (!baseConfig.containsKey(CoreOptions.TMP_DIRS_OVERRIDDEN)){
    +                   cfg.setString(CoreOptions.TMP_DIRS, "");        // 
HACK: emulate removal for the given key
    +           }
    --- End diff --
    
    I would suggest to add a 
`BootstratpTools#cloneConfiguration(Configuration)` method which clones the 
given `Configuration` and resets all node specific fields. One of these fields 
is `CoreOptions#TMP_DIRS`. This means if `USE_LOCAL_DEFAULT_TMP_DIRS` is true, 
then we clear the `TMP_DIRS` option. We actually need for that a 
`Configuration#clear(ConfigOption)` method which removes the option entry from 
`Configuration#confData`. Otherwise we might risk that we don't use the 
TMP_DIRS default value but instead `""` if there are no local default tmp dirs.


---

Reply via email to