[ https://issues.apache.org/jira/browse/FLINK-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540154#comment-16540154 ]
ASF GitHub Bot commented on FLINK-9794: --------------------------------------- Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6301 Hi @jrthe42, In general the checkpoint include two part of works. - part1: take a snapshot of the state. - part2: transfer the snapshot to the checkpoint destination(e.g. DFS) The part1 need to be sync, and the part2 can be async, if I'm not wrong. > JDBCOutputFormat does not consider idle connection and multithreads > synchronization > ----------------------------------------------------------------------------------- > > Key: FLINK-9794 > URL: https://issues.apache.org/jira/browse/FLINK-9794 > Project: Flink > Issue Type: Bug > Components: Streaming Connectors > Affects Versions: 1.4.0, 1.5.0 > Reporter: wangsan > Priority: Major > Labels: pull-request-available > > Current implementation of JDBCOutputFormat has two potential problems: > 1. The Connection was established when JDBCOutputFormat is opened, and will > be used all the time. But if this connection lies idle for a long time, the > database will force close the connection, thus errors may occur. > 2. The flush() method is called when batchCount exceeds the threshold, but it > is also called while snapshotting state. So two threads may modify upload and > batchCount, but without synchronization. > We need fix these two problems to make JDBCOutputFormat more reliable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)