[ https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535973#comment-16535973 ]
ASF GitHub Bot commented on FLINK-9407: --------------------------------------- Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6075 Thanks @hequn8128. You are very correct! It is more reasonable to put the ORC related classes into there ~, like @StephanEwen said, at the very least. make them optional. As refers to implement the ```CheckpointedFuntion```, I would not think it is necessary for it since ```BucketingSink``` have already implemented that and we just use the orc writer in this way like ```bucketingSink.setWriter(new OrcFileWriter<>(orcSchemaString))```.Also, we can take a look on ```SequenceFileWriter``` and ```StringWriter``` both do not implement ```CheckpointedFuntion```. > Support orc rolling sink writer > ------------------------------- > > Key: FLINK-9407 > URL: https://issues.apache.org/jira/browse/FLINK-9407 > Project: Flink > Issue Type: New Feature > Components: filesystem-connector > Reporter: zhangminglei > Assignee: zhangminglei > Priority: Major > Labels: patch-available, pull-request-available > > Currently, we only support {{StringWriter}}, {{SequenceFileWriter}} and > {{AvroKeyValueSinkWriter}}. I would suggest add an orc writer for rolling > sink. -- This message was sent by Atlassian JIRA (v7.6.3#76005)