Github user snuyanzin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6223#discussion_r199543936
  
    --- Diff: docs/dev/table/sql.md ---
    @@ -1510,6 +1510,17 @@ ATAN(numeric)
           </td>
         </tr>
     
    +    <tr>
    +      <td>
    +        {% highlight text %}
    +ATAN2(numeric, numeric)
    +{% endhighlight %}
    +      </td>
    +      <td>
    +        <p>Calculates the arc tangent of a given coordinate.</p>
    --- End diff --
    
    Hello @hequn8128! The idea about coordinates comes from Math.atan2 + 
Calcite's definition here [1] ATAN2(numeric, numeric) | Returns the arc tangent 
of the numeric coordinates.
    Does it make sense to take the same wording as Calcite has?
    [1] https://calcite.apache.org/docs/reference.html


---

Reply via email to