[
https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528585#comment-16528585
]
ASF GitHub Bot commented on FLINK-9456:
---------------------------------------
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6132#discussion_r199315500
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -984,6 +985,15 @@ private void startCheckpointScheduler(final
CheckpointCoordinator checkpointCoor
operatorBackPressureStats.orElse(null)));
}
+ @Override
+ public void taskManagerTerminated(ResourceID resourceID,
Set<AllocationID> allocationIds, Exception cause) {
--- End diff --
My previous thought was that `RM` needed to notify the `allocationIds` that
was assigned to `JM`, because it was possible that `SlotManager` had already
assigned slots to `JM`, but `TM` was killed before `JM` established a
connection. Mainly to address the issue in
https://issues.apache.org/jira/browse/FLINK-9351, but with the current approach
you suggested I think the problem in Flink-9351 has been fixed by the way.
> Let ResourceManager notify JobManager about failed/killed TaskManagers
> ----------------------------------------------------------------------
>
> Key: FLINK-9456
> URL: https://issues.apache.org/jira/browse/FLINK-9456
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Sihua Zhou
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.5.1
>
>
> Often, the {{ResourceManager}} learns faster about TaskManager
> failures/killings because it directly communicates with the underlying
> resource management framework. Instead of only relying on the
> {{JobManager}}'s heartbeat to figure out that a {{TaskManager}} has died, we
> should additionally send a signal from the {{ResourceManager}} to the
> {{JobManager}} if a {{TaskManager}} has died. That way, we can react faster
> to {{TaskManager}} failures and recover our running job/s.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
