[
https://issues.apache.org/jira/browse/FLINK-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526130#comment-16526130
]
ASF GitHub Bot commented on FLINK-8785:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6222
[FLINK-8785][rest] Handle JobSubmissionExceptions
## What is the purpose of the change
This PR modifies the `JobSubmitHandler` to handle exceptions contained in
the future returned by `DispatcherGateway#submitJob`.
An exception handler was added via `CompletableFuture#exceptionally` to
return a proper `ErrorResponseBody` signaling that the job submission has
failed.
This PR is pretty much the bare-bones solution; in the JIRA I advocated for
including error messages from exceptions since there are various reasons why
the submission could fail, but I can't find a satisfying solution.
## Verifying this change
* see new test in `JobSubmitHandlerTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8785_basic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6222
----
commit 32fe49270596cdcf2f91f822c3a6504a14ba40eb
Author: zentol <chesnay@...>
Date: 2018-06-28T08:57:01Z
[FLINK-8785][rest] Handle JobSubmissionExceptions
----
> JobSubmitHandler does not handle JobSubmissionExceptions
> --------------------------------------------------------
>
> Key: FLINK-8785
> URL: https://issues.apache.org/jira/browse/FLINK-8785
> Project: Flink
> Issue Type: Bug
> Components: Job-Submission, JobManager, REST
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Labels: flip-6, pull-request-available
>
> If the job submission, i.e. {{DispatcherGateway#submitJob}} fails with a
> {{JobSubmissionException}} the {{JobSubmissionHandler}} returns "Internal
> server error" instead of signaling the failed job submission.
> This can for example occur if the transmitted execution graph is faulty, as
> tested by the \{{JobSubmissionFailsITCase}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
