Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/6196
  
    Thanks for the nice contribution. I had some comments inline. In particular 
three points about the serializer. I would suggest to avoid the use of raw 
types. I would also suggest to avoid using streaming API at least methods that 
can appear in hot loops (mainly copy, de/serialize) for performance reasons. I 
think the imperative style code will not even be (much) longer in those cases. 
Last, I suggest to always test new serializers via the `SerializerTestBase` 
because this catches many problems with little effort.


---

Reply via email to