Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6199#discussion_r198030793
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
---
@@ -114,17 +114,12 @@ public JarRunHandler(
CompletableFuture<JobGraph> jarUploadFuture =
jobGraphFuture.thenCombine(blobServerPortFuture, (jobGraph, blobServerPort) -> {
final InetSocketAddress address = new
InetSocketAddress(getDispatcherHost(gateway), blobServerPort);
- final List<PermanentBlobKey> keys;
- try {
- keys = BlobClient.uploadFiles(address,
configuration, jobGraph.getJobID(), jobGraph.getUserJars());
+ try (BlobClient blobClient = new BlobClient(address,
configuration)) {
+ ClientUtils.uploadAndSetUserJars(jobGraph,
blobClient);
--- End diff --
But it would reduce code redundancy, right? If this is the case, then let's
do it.
---
