[ 
https://issues.apache.org/jira/browse/FLINK-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520531#comment-16520531
 ] 

ASF GitHub Bot commented on FLINK-8983:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6083#discussion_r197490461
  
    --- Diff: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml ---
    @@ -0,0 +1,155 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +   <parent>
    +           <artifactId>flink-end-to-end-tests</artifactId>
    +           <groupId>org.apache.flink</groupId>
    +           <version>1.6-SNAPSHOT</version>
    +   </parent>
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <artifactId>flink-confluent-schema-registry</artifactId>
    +   <properties>
    +           
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +           <confluent.version>3.2.0</confluent.version>
    +   </properties>
    +
    +   <repositories>
    +           <repository>
    +                   <id>confluent</id>
    +                   <url>http://packages.confluent.io/maven/</url>
    +           </repository>
    +   </repositories>
    +
    +   <dependencies>
    +           <!-- Apache Flink dependencies -->
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-core</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <!-- This dependency is required to actually execute 
jobs. It is currently pulled in by
    +                flink-streaming-java, but we explicitly depend on it to 
safeguard against future changes. -->
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-clients_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <!-- 
https://mvnrepository.com/artifact/org.apache.flink/flink-connector-kafka-0.10 
-->
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-avro</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>io.confluent</groupId>
    +                   <artifactId>kafka-avro-serializer</artifactId>
    +                   <version>${confluent.version}</version>
    +           </dependency>
    +   </dependencies>
    +
    +   <build>
    +           <plugins>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    +                           <version>3.0.0</version>
    +                           <executions>
    +                                   <execution>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>shade</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   
<finalName>TestAvroConsumerConfluent</finalName>
    +                                                   <artifactSet>
    +                                                           <excludes>
    +                                                                   
<exclude>com.google.code.findbugs:jsr305</exclude>
    +                                                           </excludes>
    +                                                   </artifactSet>
    +                                                   <filters>
    +                                                           <filter>
    +                                                                   
<artifact>*:*</artifact>
    +                                                                   
<excludes>
    +                                                                           
<exclude>META-INF/*.SF</exclude>
    +                                                                           
<exclude>META-INF/*.DSA</exclude>
    +                                                                           
<exclude>META-INF/*.RSA</exclude>
    +                                                                   
</excludes>
    +                                                           </filter>
    +                                                   </filters>
    +                                                   <transformers>
    +                                                           <transformer 
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
    +                                                                   
<mainClass>org.apache.flink.schema.registry.test.TestAvroConsumerConfluent</mainClass>
    +                                                           </transformer>
    +                                                   </transformers>
    +                                           </configuration>
    +                                   </execution>
    +                           </executions>
    +                   </plugin>
    +                   <plugin>
    +                           <groupId>org.apache.avro</groupId>
    +                           <artifactId>avro-maven-plugin</artifactId>
    +                           <version>${avro.version}</version>
    +                           <executions>
    +                                   <execution>
    +                                           <phase>generate-sources</phase>
    +                                           <goals>
    +                                                   <goal>schema</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   
<sourceDirectory>${project.basedir}/src/main/avro/</sourceDirectory>
    +                                                   
<outputDirectory>${project.basedir}/src/main/java/</outputDirectory>
    +                                                   
<fieldVisibility>PRIVATE</fieldVisibility>
    +                                                   <includes>
    +                                                           
<include>**/*.avsc</include>
    +                                                   </includes>
    +                                           </configuration>
    +                                   </execution>
    +                           </executions>
    +                   </plugin>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-enforcer-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <id>dependency-convergence</id>
    +                                           <goals>
    +                                                   <goal>enforce</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   <skip>true</skip>
    +                                           </configuration>
    +                                   </execution>
    +                           </executions>
    +                   </plugin>
    --- End diff --
    
    Do we need the `maven-enforcer-plugin` here?


> End-to-end test: Confluent schema registry
> ------------------------------------------
>
>                 Key: FLINK-8983
>                 URL: https://issues.apache.org/jira/browse/FLINK-8983
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kafka Connector, Tests
>            Reporter: Till Rohrmann
>            Assignee: Yazdan Shirvany
>            Priority: Critical
>              Labels: pull-request-available
>
> It would be good to add an end-to-end test which verifies that Flink is able 
> to work together with the Confluent schema registry. In order to do that we 
> have to setup a Kafka cluster and write a Flink job which reads from the 
> Confluent schema registry producing an Avro type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to