[ https://issues.apache.org/jira/browse/FLINK-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519181#comment-16519181 ]
ASF GitHub Bot commented on FLINK-9543: --------------------------------------- GitHub user lamber-ken opened a pull request: https://github.com/apache/flink/pull/6195 [FLINK-9543][METRICS] Expose JobMaster ID to metric system ## What is the purpose of the change This pull request makes flink can expose JM_ID to metric system ## Brief change log - Expose JobMaster ID to metric system ## Verifying this change This change is already covered by existing tests. [prometheus test](https://github.com/apache/flink/tree/master/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus) ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lamber-ken/flink lamber-ken-fix-FLINK-9543 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6195 ---- commit 1a8e1f6193823e70b1dc6abc1146299042c25c7d Author: lamber-ken <!@...> Date: 2018-06-20T04:26:10Z add prometheus pushgateway reporter commit cd0a07b82513c686e22c1598e78351a5b0a128b3 Author: lamber-ken <!@...> Date: 2018-06-21T08:19:00Z back to flink/origin/master commit 8ec3eb19ce80cac87d81dd8b4523a4f65061ab11 Author: lamber-ken <!@...> Date: 2018-06-21T09:59:32Z expose JobMaster ID to metric system ---- > Expose JobMaster IDs to metric system > ------------------------------------- > > Key: FLINK-9543 > URL: https://issues.apache.org/jira/browse/FLINK-9543 > Project: Flink > Issue Type: New Feature > Components: Local Runtime, Metrics > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Priority: Major > Labels: pull-request-available > Fix For: 1.6.0 > > > To be able to differentiate between metrics from different taskmanagers we > should expose the Jobmanager ID (i.e. the resourceID) to the metric system, > like we do for TaskManagers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)