Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6173#discussion_r196042694
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
 ---
    @@ -67,6 +79,21 @@
     
        private static final Logger LOG = 
LoggerFactory.getLogger(QueryableStateClient.class);
     
    +   private static final Map<Class<? extends StateDescriptor>, 
StateFactory> STATE_FACTORIES =
    +           
org.apache.flink.shaded.guava18.com.google.common.collect.ImmutableMap
    --- End diff --
    
    We have unmodifiable map alternatives in the JDK. If there is not a good 
reason why we need guava here, I would suggest to solve this without this 
import. Even in that case, I would use import and not fully qualified classname.


---

Reply via email to