[ 
https://issues.apache.org/jira/browse/FLINK-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512655#comment-16512655
 ] 

ASF GitHub Bot commented on FLINK-8983:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6083#discussion_r195465088
  
    --- Diff: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml ---
    @@ -0,0 +1,228 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +   <parent>
    +           <artifactId>flink-end-to-end-tests</artifactId>
    +           <groupId>org.apache.flink</groupId>
    +           <version>1.6-SNAPSHOT</version>
    +   </parent>
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <artifactId>flink-confluent-schema-registry</artifactId>
    +   <properties>
    +           
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +           <scala.binary.version>2.11</scala.binary.version>
    +           <confluent.version>4.1.0</confluent.version>
    +           <json2avro.version>0.2.6</json2avro.version>
    +           <maven.compiler.source>1.8</maven.compiler.source>
    +   </properties>
    +
    +   <dependencies>
    +           <!-- Apache Flink dependencies -->
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-core</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <!-- This dependency is required to actually execute 
jobs. It is currently pulled in by
    +                flink-streaming-java, but we explicitly depend on it to 
safeguard against future changes. -->
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-clients_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-scala_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-streaming-scala_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <!-- 
https://mvnrepository.com/artifact/org.apache.flink/flink-connector-kafka-0.10 
-->
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-connector-kafka-0.8_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <!-- 
https://mvnrepository.com/artifact/org.apache.flink/flink-avro -->
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-avro</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <!-- https://mvnrepository.com/artifact/org.apache.avro/avro -->
    +           <dependency>
    +                   <groupId>org.apache.avro</groupId>
    +                   <artifactId>avro</artifactId>
    +           </dependency>
    +           <dependency>
    +                   <groupId>io.confluent</groupId>
    +                   <artifactId>kafka-avro-serializer</artifactId>
    +                   <version>${confluent.version}</version>
    +           </dependency>
    +           <!-- 
https://mvnrepository.com/artifact/tech.allegro.schema.json2avro/converter -->
    +           <dependency>
    +                   <groupId>tech.allegro.schema.json2avro</groupId>
    +                   <artifactId>converter</artifactId>
    +                   <version>${json2avro.version}</version>
    +           </dependency>
    +   </dependencies>
    +
    +   <profiles>
    +           <profile>
    +                   <!-- Profile for packaging correct JAR files -->
    +                   <id>build-jar</id>
    +                   <activation>
    +                           <activeByDefault>false</activeByDefault>
    +                   </activation>
    +                   <build>
    +                           <resources>
    +                                   <resource>
    +                                           
<directory>src/main/resources/${resource.dir}</directory>
    +                                           <filtering>true</filtering>
    +                                   </resource>
    +                           </resources>
    +                           <plugins>
    +                                   <!-- We use the maven-shade plugin to 
create a fat jar that contains all dependencies
    +                        except flink and its transitive dependencies. The 
resulting fat-jar can be executed
    +                        on a cluster. Change the value of Program-Class if 
your program entry point changes. -->
    +                                   <plugin>
    +                                           
<groupId>org.apache.maven.plugins</groupId>
    +                                           
<artifactId>maven-shade-plugin</artifactId>
    +                                           <version>2.4.1</version>
    +                                           <executions>
    +                                                   <!-- Run shade goal on 
package phase -->
    +                                                   <execution>
    +                                                           
<phase>package</phase>
    +                                                           <goals>
    +                                                                   
<goal>shade</goal>
    +                                                           </goals>
    +                                                           <configuration>
    +                                                                   
<artifactSet>
    +                                                                           
<excludes>
    +                                                                           
        <exclude>org.apache.flink:force-shading</exclude>
    +                                                                           
        <exclude>com.google.code.findbugs:jsr305</exclude>
    +                                                                           
        <exclude>org.slf4j:*</exclude>
    +                                                                           
</excludes>
    +                                                                   
</artifactSet>
    +                                                                   
<filters>
    +                                                                           
<filter>
    +                                                                           
        <!-- Do not copy the signatures in the META-INF folder.
    +                                            Otherwise, this might cause 
SecurityExceptions when using the JAR. -->
    +                                                                           
        <artifact>*:*</artifact>
    +                                                                           
        <excludes>
    +                                                                           
                <exclude>META-INF/*.SF</exclude>
    +                                                                           
                <exclude>META-INF/*.DSA</exclude>
    +                                                                           
                <exclude>META-INF/*.RSA</exclude>
    +                                                                           
        </excludes>
    +                                                                           
</filter>
    +                                                                   
</filters>
    +                                                                   <!-- If 
you want to use ./bin/flink run <quickstart jar> uncomment the following lines.
    +                                        This will add a Main-Class entry 
to the manifest file -->
    +                                                                   <!--
    +                                    -->
    +                                                                   
<transformers>
    +                                                                           
<transformer
    +                                                                           
        
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
    +                                                                           
        <mainClass>
    +                                                                           
                TestAvroConsumerConfluent
    +                                                                           
        </mainClass>
    +                                                                           
</transformer>
    +                                                                   
</transformers>
    +                                                           </configuration>
    +                                                   </execution>
    +                                           </executions>
    +                                   </plugin>
    +                           </plugins>
    +                   </build>
    +           </profile>
    +   </profiles>
    +   <repositories>
    +           <repository>
    +                   <id>confluent</id>
    +                   <url>http://packages.confluent.io/maven/</url>
    +           </repository>
    +   </repositories>
    +   <build>
    +           <plugins>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-compiler-plugin</artifactId>
    +                           <version>3.1</version>
    +                           <configuration>
    +                                   <source>1.8</source>
    +                                   <target>1.8</target>
    +                           </configuration>
    +                   </plugin>
    +                   <plugin>
    +                           <groupId>net.alchim31.maven</groupId>
    +                           <artifactId>scala-maven-plugin</artifactId>
    +                           <version>3.2.2</version>
    +                           <executions>
    +                                   <execution>
    +                                           <goals>
    +                                                   <goal>compile</goal>
    +                                                   <goal>testCompile</goal>
    +                                           </goals>
    +                                   </execution>
    +                           </executions>
    +                   </plugin>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-release-plugin</artifactId>
    +                           <version>2.5.2</version>
    +                           <configuration>
    +                                   
<tagNameFormat>@{project.version}</tagNameFormat>
    +                           </configuration>
    +                   </plugin>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-enforcer-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <id>dependency-convergence</id>
    +                                           <goals>
    +                                                   <goal>enforce</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   <skip>true</skip>
    +                                           </configuration>
    +                                   </execution>
    +                           </executions>
    +                   </plugin>
    +                   <plugin>
    +                           <artifactId>maven-checkstyle-plugin</artifactId>
    +                           <configuration>
    +                                   <skip>true</skip>
    +                           </configuration>
    +                   </plugin>
    +           </plugins>
    +   </build>
    --- End diff --
    
    Let's replace all this with
    ```
    <build>
                <plugins>
                        <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-shade-plugin</artifactId>
                                <version>3.0.0</version>
                                <executions>
                                        <execution>
                                                <phase>package</phase>
                                                <goals>
                                                        <goal>shade</goal>
                                                </goals>
                                                <configuration>
                                                        
<finalName>Elasticsearch2SinkExample</finalName>
                                                        <artifactSet>
                                                                <excludes>
                                                                        
<exclude>com.google.code.findbugs:jsr305</exclude>
                                                                </excludes>
                                                        </artifactSet>
                                                        <filters>
                                                                <filter>
                                                                        
<artifact>*:*</artifact>
                                                                        
<excludes>
                                                                                
<exclude>META-INF/*.SF</exclude>
                                                                                
<exclude>META-INF/*.DSA</exclude>
                                                                                
<exclude>META-INF/*.RSA</exclude>
                                                                        
</excludes>
                                                                </filter>
                                                        </filters>
                                                        <transformers>
                                                                <transformer 
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
                                                                        
<mainClass>org.apache.flink.streaming.tests.Elasticsearch2SinkExample</mainClass>
                                                                </transformer>
                                                        </transformers>
                                                </configuration>
                                        </execution>
                                </executions>
                        </plugin>
                </plugins>
        </build>
    ```
    modulo the name of the `mainClass`.


> End-to-end test: Confluent schema registry
> ------------------------------------------
>
>                 Key: FLINK-8983
>                 URL: https://issues.apache.org/jira/browse/FLINK-8983
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kafka Connector, Tests
>            Reporter: Till Rohrmann
>            Assignee: Yazdan Shirvany
>            Priority: Critical
>
> It would be good to add an end-to-end test which verifies that Flink is able 
> to work together with the Confluent schema registry. In order to do that we 
> have to setup a Kafka cluster and write a Flink job which reads from the 
> Confluent schema registry producing an Avro type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to