[
https://issues.apache.org/jira/browse/FLINK-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512183#comment-16512183
]
ASF GitHub Bot commented on FLINK-9560:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195341250
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
@@ -278,15 +278,15 @@
* Unlimited be default.
*/
public static ConfigOption<Long>
rateLimitingInputBytesPerSeconds(String scheme) {
- return ConfigOptions.key("fs." + scheme +
".limit.rateLimitingInput").defaultValue(0L);
+ return ConfigOptions.key("fs." + scheme +
".limit.input-rate-limit").defaultValue(0L);
--- End diff --
Please rename also variables/methods to match the new config name and match
the other properties above:
`s/rateLimitingInputBytesPerSeconds/fileSystemConnectionLimitInputRate/g`
`s/rateLimitingOututBytesPerSeconds/fileSystemConnectionLimitOutputRate/g`
> RateLimiting for FileSystem
> ---------------------------
>
> Key: FLINK-9560
> URL: https://issues.apache.org/jira/browse/FLINK-9560
> Project: Flink
> Issue Type: Improvement
> Components: FileSystem
> Affects Versions: 1.5.0
> Reporter: Etienne CARRIERE
> Priority: Major
>
> *Pain*: On our system, we see that during checkpoint , all the bandwidth is
> take to send the checkpoint to object storage (s3 in our case)
> *Proposal* : After the creation of some limitation on Filesystem (mostly
> number of connections with the tickets FLINK-8125/FLINK-8198/FLINK-9468), I
> propose to add ratelimiting "per Filesystem" .
> *Proposal of implementation* : Modify LimitedConnectionsFileSystem to add a
> ratelimiter on both Input and OutputStream.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
