Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195344817
--- Diff:
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java
---
@@ -132,7 +132,12 @@ else if (scheme != null && authority == null) {
final S3AFileSystem fs = new S3AFileSystem();
fs.initialize(fsUri, hadoopConfig);
- return new HadoopFileSystem(fs);
+ if (flinkConfig != null) {
--- End diff --
Can you pull this if into `HadoopUtils.limitIfConfigured` method? That way
those invocations would simply look like: `limitIfConfigured(new
HadoopFileSystem(fs), scheme, Optional.ofNullable(flinkConfig))` without
duplicated it/else branch.
---
