Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6147#discussion_r195101445
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
    @@ -197,6 +208,88 @@ public void shutdown(Time timeout) {
                                executor);
        }
     
    +   public <M extends MessageHeaders<R, P, U>, U extends MessageParameters, 
R extends RequestBody, P extends ResponseBody> CompletableFuture<P> sendRequest(
    +                   String targetAddress,
    +                   int targetPort,
    +                   M messageHeaders,
    +                   U messageParameters,
    +                   R request,
    +                   Collection<Path> jars,
    +                   Collection<Path> userArtifacts) throws IOException {
    --- End diff --
    
    So far we managed to not expose netty stuff in the `RestClient` API, I 
would prefer if we didn't start now.
    
    Could we not just pass a single `Collection<Path>` instead? The 
content-type would then always be `application/octet-stream`.


---

Reply via email to