Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r195081885
--- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+source "${END_TO_END_DIR}"/test-scripts/common.sh
+
+#######################################
+# Prints the given description, runs the given test and prints how long
the execution took.
+# Arguments:
+# $1: description of the test
+# $2: command to execute
+#######################################
+function run_test {
+ description="$1"
+ command="$2"
+
+ printf
"\n==============================================================================\n"
+ printf "Running '${description}'\n"
+ printf
"==============================================================================\n"
+ start_timer
+ ${command}
+ exit_code="$?"
+ time_elapsed=$(end_timer)
+
+ check_logs_for_errors
+ check_logs_for_exceptions
+ check_logs_for_non_empty_out_files
+
+ cleanup
+
+ if [[ ${exit_code} == 0 ]]; then
--- End diff --
Oh that is still in there b.c. I left the
`check_logs_for_non_empty_out_files` etc. untouched, which again use the `PASS`
thing to signal whether or not a test case should fail.
I'll go ahead and change this to our new convention as well.
At least it's nothing went wrong during the rebase ð
---
