Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6156#discussion_r194796355
  
    --- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
 ---
    @@ -94,6 +94,11 @@ public RocksDBListState(
                return valueSerializer;
        }
     
    +   @Override
    +   public byte[] getSerializedValue(byte[] serializedKeyAndNamespace, 
TypeSerializer<K> safeKeySerializer, TypeSerializer<N> safeNamespaceSerializer, 
TypeSerializer<List<V>> safeValueSerializer) throws Exception {
    +           return new byte[0];
    --- End diff --
    
    Maybe we could use a static field to avoid to new the `byte[0]` every time.


---

Reply via email to