[ https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505757#comment-16505757 ]
ASF GitHub Bot commented on FLINK-8468: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193964437 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.rabbitmq; + +import org.apache.flink.annotation.PublicEvolving; + +import com.rabbitmq.client.AMQP.BasicProperties; + +/** + * The message computation provides methods to compute the message routing key and/or the properties. + * + * @param <IN> The type of the data used by the sink. + */ +@PublicEvolving +public interface RMQSinkPublishOptions<IN> extends java.io.Serializable { + + /** + * Compute the message's routing key from the data. + * @param a The data used by the sink + * @return The routing key of the message + */ + String computeRoutingKey(IN a); + + /** + * Compute the message's properties from the data. + * @param a The data used by the sink + * @return The message's properties (can be null) + */ + BasicProperties computeProperties(IN a); + + /** + * Compute the exchange from the data. + * @param a The data used by the sink + * @return The exchange to publish the message to + */ + String computeExchange(IN a); + + /** + * Compute the mandatory flag used in basic.publish method + * See AMQP API help for values. + * A ReturnListener is mandatory if this flag can be true (if not it is ignored and forced to false) + * @param a The data used by the sink + * @return The mandatory flag + */ + boolean computeMandatory(IN a); --- End diff -- ping > Make the connector to take advantage of AMQP features (routing key, exchange > and message properties) > ---------------------------------------------------------------------------------------------------- > > Key: FLINK-8468 > URL: https://issues.apache.org/jira/browse/FLINK-8468 > Project: Flink > Issue Type: Improvement > Components: RabbitMQ Connector > Affects Versions: 1.4.0 > Reporter: Ph.Duveau > Priority: Major > > Make the connector to take advantage of AMQP features by adding a constructor > and an interface to implement -- This message was sent by Atlassian JIRA (v7.6.3#76005)