Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126744
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22 @@ public void throwExceptionIfChannelIsNull() throws
Exception {
}
private RMQSink<String> createRMQSink() throws Exception {
- RMQSink rmqSink = new RMQSink<String>(rmqConnectionConfig,
QUEUE_NAME, serializationSchema);
+ RMQSink<String> rmqSink = new
RMQSink<String>(rmqConnectionConfig, QUEUE_NAME, serializationSchema);
+ rmqSink.open(new Configuration());
+ return rmqSink;
+ }
+
+ private RMQSink<String> createRMQSinkFeatured() throws Exception {
--- End diff --
How about `createRMQSinkWithPublishOptions()`? I am not a AMQP specialist,
if `RMQSinkFeatured` has a special meaning, then leave it.
---
