Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6021#discussion_r192837000
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
 ---
    @@ -180,9 +204,16 @@ public void open(Configuration parameters) throws 
Exception {
                KinesisProducerConfiguration producerConfig = 
KinesisConfigUtil.getValidatedProducerConfiguration(configProps);
     
                producer = getKinesisProducer(producerConfig);
    +
    +           final MetricGroup kinesisMectricGroup = 
getRuntimeContext().getMetricGroup().addGroup("kinesisProducer");
    --- End diff --
    
    minor: better to make these three strings constant (static final String) 
for easier maintenance.


---

Reply via email to