[ 
https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495248#comment-16495248
 ] 

Till Rohrmann commented on FLINK-9461:
--------------------------------------

If {{flink-table}} would only contain some interfaces defining the sources, 
sinks and operators, then it would not be a big problem. But this is obviously 
not the case. The point I'm trying to make is that it feels a bit odd that a 
Flink connector depends on a Flink library while it would be so simple to get 
rid of it by introducing a dedicated module.

Assume that we might get rid of the Scala dependency in {{flink-runtime}}, then 
we could still not remove the Scala suffix from the connectors because they 
depend on {{flink-table}}.

> Disentangle flink-connector-kafka from flink-table and flink-json
> -----------------------------------------------------------------
>
>                 Key: FLINK-9461
>                 URL: https://issues.apache.org/jira/browse/FLINK-9461
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Priority: Major
>             Fix For: 1.6.0
>
>
> Currently, the {{flink-connector-kafka}} module has a dependency on 
> {{flink-table}} and {{flink-json}}. The reason seems to be that the module 
> contains the {{KafkaJsonTableSource}} and {{KafkaJsonTableSink}}. Even though 
> the {{flink-table}} and {{flink-json}} dependency are marked as optional, the 
> {{flink-connector-kafka}} will still contain the table sources and sinks. I 
> think this is not a clean design.
> I would propose to move the table sources and sinks into a dedicated module 
> which depends on {{flink-connector-kafka}}. That way we would better separate 
> dependencies and could remove {{flink-table}} and {{flink-json}} from 
> {{flink-connector-kafka}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to