Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6062#discussion_r191732272
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java
 ---
    @@ -96,7 +96,7 @@ public 
AbstractInternalTimersSnapshotWriter(InternalTimersSnapshot<K, N> timersS
                public final void writeTimersSnapshot(DataOutputView out) 
throws IOException {
                        writeKeyAndNamespaceSerializers(out);
     
    -                   InternalTimer.TimerSerializer<K, N> timerSerializer = 
new InternalTimer.TimerSerializer<>(
    +                   TimerHeapInternalTimer.TimerSerializer<K, N> 
timerSerializer = new TimerHeapInternalTimer.TimerSerializer<>(
    --- End diff --
    
    I think this is ok for the moment and we can adjust in case there will ever 
be another implementation of `InternalTimer `


---

Reply via email to