[ 
https://issues.apache.org/jira/browse/FLINK-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642434#comment-14642434
 ] 

ASF GitHub Bot commented on FLINK-2324:
---------------------------------------

Github user gyfora commented on the pull request:

    https://github.com/apache/flink/pull/937#issuecomment-125125052
  
    After playing around with the StreamCheckpointingITCase, it seems like we 
actually don't even have at least once guarantees because of some bug in the 
implementation (either in the barrier buffer or with the event alignment):
    
    The RichFlatMap that did the counting (preceeded by a groupBy) did not 
always count the correct number of inputs or prefixes (meaning the state was 
checkpointed earlier than it should have been).
    
    What was interesting that all other operators counted exactly the right 
amount of inputs all the time, then I realised they were all forward connected 
(pointwise connection pattern which didnt trigger any blocking logic in the 
barrier buffer). So I changed the connection between the filter and map to 
shuffle, and now that map also fails sometimes on incorrect number of inputs 
received.
    
    I will try rebasing this on @StephanEwen 's barrier buffer rework in 
https://github.com/apache/flink/pull/938, let's see if that fixes it. 


> Rework partitioned state storage
> --------------------------------
>
>                 Key: FLINK-2324
>                 URL: https://issues.apache.org/jira/browse/FLINK-2324
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Gyula Fora
>            Assignee: Gyula Fora
>
> Partitioned states are currently stored per-key in statehandles. This is 
> alright for in-memory storage but is very inefficient for HDFS. 
> The logic behind the current mechanism is that this approach provides a way 
> to repartition a state without fetching the data from the external storage 
> and only manipulating handles.
> We should come up with a solution that can achieve both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to