[
https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492710#comment-16492710
]
ASF GitHub Bot commented on FLINK-6469:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191186380
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -176,19 +188,19 @@
/**
* Size of memory buffers used by the network stack and the memory
manager (in bytes).
*/
- public static final ConfigOption<Integer> MEMORY_SEGMENT_SIZE =
+ public static final ConfigOption<String> MEMORY_SEGMENT_SIZE =
key("taskmanager.memory.segment-size")
- .defaultValue(32768)
- .withDescription("Size of memory buffers used by the
network stack and the memory manager (in bytes).");
+ .defaultValue("32768")
+ .withDescription("Size of memory buffers used by the
network stack and the memory manager.");
/**
* Amount of memory to be allocated by the task manager's memory
manager (in megabytes). If not
--- End diff --
remove (in megabytes)
> Configure Memory Sizes with units
> ---------------------------------
>
> Key: FLINK-6469
> URL: https://issues.apache.org/jira/browse/FLINK-6469
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> Currently, memory sizes are configured by pure numbers, the interpretation is
> different from configuration parameter to parameter.
> For example, heap sizes are configured in megabytes, network buffer memory is
> configured in bytes, alignment thresholds are configured in bytes.
> I propose to configure all memory parameters the same way, with units similar
> to time. The JVM itself configured heap size similarly: {{Xmx5g}} or
> {{Xmx2000m}}.
> {code}
> 10000 -> bytes
> 10 kb
> 64 mb
> 1 gb
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
