[
https://issues.apache.org/jira/browse/FLINK-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484028#comment-16484028
]
ASF GitHub Bot commented on FLINK-9378:
---------------------------------------
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6032
@twalthr thank you for your review.
To be honest thought about such approach indeed
org.apache.flink.api.common.typeinfo.BasicTypeInfo#toString should be changed
at least to fix case from here
https://issues.apache.org/jira/browse/FLINK-9341?focusedCommentId=16475693&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16475693
.
So I have 2 questions:
1. is it ok to change public api behavior here (toString is public)?
2. Should we go through all successors of
org.apache.flink.api.common.typeinfo.TypeInformation and if its toString looks
like clazz.getSimpleName than change it similar to
org.apache.flink.api.java.typeutils.GenericTypeInfo#toString?
could you please clarify it and than I could do required corrections
> Improve TableException message with TypeName usage
> --------------------------------------------------
>
> Key: FLINK-9378
> URL: https://issues.apache.org/jira/browse/FLINK-9378
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Sergey Nuyanzin
> Assignee: Sergey Nuyanzin
> Priority: Trivial
>
> Currently in TableException simple name is in use. It is not clear what is
> the issue while having error message like {noformat}
> Exception in thread "main" org.apache.flink.table.api.TableException: Result
> field does not match requested type. Requested: Date; Actual: Date
> at
> org.apache.flink.table.api.TableEnvironment$$anonfun$generateRowConverterFunction$1.apply(TableEnvironment.scala:953)
> {noformat}
> or
> {noformat}Caused by: org.apache.flink.table.api.TableException: Type is not
> supported: Date
> at
> org.apache.flink.table.api.TableException$.apply(exceptions.scala:53){noformat}
> also for more detailed have a look at FLINK-9341
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
