[ 
https://issues.apache.org/jira/browse/FLINK-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480866#comment-16480866
 ] 

ASF GitHub Bot commented on FLINK-9400:
---------------------------------------

GitHub user thinkerou opened a pull request:

    https://github.com/apache/flink/pull/6042

    [FLINK-9400] change import statement for flink-scala

    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    
    When I read `flink-scala` code, I found like the below code:
    
    ```scala
    import org.apache.flink.api.common.operators.Keys
    import Keys.ExpressionKeys
    ```
    
    So, I want to fix it, use the follow code:
    
    ```scala
    import org.apache.flink.api.common.operators.Keys.ExpressionKeys
    ```
    
    ## Brief change log
    
    - normalize scala import statement
    
    ## Verifying this change
    
    This change is already covered by existing tests, test pass.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes)
      - The serializers: (don't know)
      - The runtime per-record code paths (performance sensitive): (don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (don't know)
      - The S3 file system connector: (don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thinkerou/flink im

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6042
    
----
commit 5ded44fb0ecc27007bce837c519b8e140504f879
Author: thinkerou <thinkerou@...>
Date:   2018-05-18T16:02:01Z

    [FLINK-9400] change import statement for flink-scala

----


> change import statement for flink-scala
> ---------------------------------------
>
>                 Key: FLINK-9400
>                 URL: https://issues.apache.org/jira/browse/FLINK-9400
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala API
>    Affects Versions: 1.4.1
>            Reporter: thinkerou
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: 1.6.0
>
>
> At `flink-scala` project have the follow import statement:
>  
> ```scala
> import org.apache.flink.api.common.operators.Keys
> import Keys.ExpressionKeys
> ```
> So I want to commit one pull request to fix it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to