[ 
https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479047#comment-16479047
 ] 

ASF GitHub Bot commented on FLINK-9008:
---------------------------------------

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5823
  
    Hi, @tzulitai I have updated the code according to your suggestions. It is 
the time for another review, could you take a look ? Thank you very much.
    
     And the below is the test result on my local machine. Tests looks good.
    
    ```
    Elasticsearch node is running.
    Starting cluster.
    Starting standalonesession daemon on host zhangmingleideMacBook-Pro.local.
    Starting taskexecutor daemon on host zhangmingleideMacBook-Pro.local.
    Dispatcher/TaskManagers are not yet up
    Waiting for dispatcher REST endpoint to come up...
    Dispatcher/TaskManagers are not yet up
    Waiting for dispatcher REST endpoint to come up...
    Dispatcher/TaskManagers are not yet up
    Waiting for dispatcher REST endpoint to come up...
    Waiting for dispatcher REST endpoint to come up...
    Dispatcher REST endpoint is up.
    Starting execution of program
    Program execution finished
    Job with JobID b527720074fcb49665ab03216abbcd5b has finished.
    Job Runtime: 1843 ms
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  
Current
                                     Dload  Upload   Total   Spent    Left  
Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:100  
3470  100  3470    0     0  37739      0 --:--:-- --:--:-- --:--:-- 38131
    Quickstarts end to end test pass.
    Stopping taskexecutor daemon (pid: 67722) on host 
zhangmingleideMacBook-Pro.local.
    Stopping standalonesession daemon (pid: 67428) on host 
zhangmingleideMacBook-Pro.local.
    No zookeeper daemon to stop on host zhangmingleideMacBook-Pro.local.
    All tests PASS
    ```


> End-to-end test: Quickstarts
> ----------------------------
>
>                 Key: FLINK-9008
>                 URL: https://issues.apache.org/jira/browse/FLINK-9008
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Quickstarts, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Blocker
>             Fix For: 1.6.0
>
>
> We could add an end-to-end test which verifies Flink's quickstarts. It should 
> do the following:
> # create a new Flink project using the quickstarts archetype 
> # add a new Flink dependency to the {{pom.xml}} (e.g. Flink connector or 
> library) 
> # run {{mvn clean package -Pbuild-jar}}
> # verify that no core dependencies are contained in the jar file
> # Run the program



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to