[ 
https://issues.apache.org/jira/browse/FLINK-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473445#comment-16473445
 ] 

ASF GitHub Bot commented on FLINK-9292:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5970#discussion_r187797400
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
    @@ -62,6 +62,10 @@
     @SuppressWarnings("serial")
     public class UdfAnalyzerTest {
     
    +   private static TypeInformation<Tuple2<String, Integer>> 
stringIntTuple2TypeInfo = TypeInformation.of(new TypeHint<Tuple2<String, 
Integer>>(){});
    --- End diff --
    
    These fields are constants, so they should be final. Can you add the 
modified and rename the fields to match the naming convention?


> Remove TypeInfoParser
> ---------------------
>
>                 Key: FLINK-9292
>                 URL: https://issues.apache.org/jira/browse/FLINK-9292
>             Project: Flink
>          Issue Type: Task
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: vinoyang
>            Priority: Major
>
> The {{TypeInfoParser}} has been deprecated, in favor of the {{TypeHint}}.
> Because the TypeInfoParser is also not working correctly with respect to 
> classloading, we should remove it. Users still find the class, try to use it, 
> and run into problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to