Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5908#discussion_r185730033
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java
 ---
    @@ -97,6 +105,32 @@ public String toString() {
                                '}';
        }
     
    +   public String buildHashKey() {
    +           return this.hashKey;
    +   }
    +
    +   public static String buildHashKey(String key, String namespace, long 
timestamp) {
    +           return key + ":" + namespace + ":" + timestamp;
    +   }
    +
    +   public void markDelete(int deleteVersion) {
    +           synchronized (this.deleteVersion) {
    --- End diff --
    
    What is the use of this synchronization on a non-final field that cannot be 
achieved with a volatile field?


---

Reply via email to