[ https://issues.apache.org/jira/browse/FLINK-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460797#comment-16460797 ]
ASF GitHub Bot commented on FLINK-8978: --------------------------------------- GitHub user azagrebin opened a pull request: https://github.com/apache/flink/pull/5947 [FLINK-8978] Stateful generic stream job upgrade e2e test ## What is the purpose of the change e2e test for generic state job upgrade and state recovery based operator uid. ## Brief change log - extract `DataStreamAllroundTestJobFactory` from `DataStreamAllroundTestProgram` to reuse generic components and their cli config. - extract some code snippets into functions from `test_scripts/test_resume_savepoint.sh` to `test_scripts/common.sh` to reuse them in this new test - add `flink-stream-stateful-job-upgrade-test` module to flink e2e tests - add `StatefulStreamJobUpgradeTestProgram` which is constructed from `DataStreamAllroundTestJobFactory` - add `test_scripts/test_stateful_stream_job_upgrade.sh` to `run-nightly-tests.sh` ## Verifying this change run from flink repo root ```bash $ mvn clean package $ FLINK_DIR=build-target flink-end-to-end-tests/test-scripts/test_stateful_stream_job_upgrade.sh ``` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/azagrebin/flink FLINK-8978 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5947.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5947 ---- commit 4282b9cee00dafd4963a3a9902e63cc0fa77d385 Author: Andrey Zagrebin <andrey.zagrebin@...> Date: 2018-04-30T18:25:53Z [FLINK-8978] Stateful generic stream job upgrade e2e test ---- > End-to-end test: Job upgrade > ---------------------------- > > Key: FLINK-8978 > URL: https://issues.apache.org/jira/browse/FLINK-8978 > Project: Flink > Issue Type: Sub-task > Components: Tests > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Andrey Zagrebin > Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > Job upgrades usually happen during the lifetime of a real world Flink job. > Therefore, we should add an end-to-end test which exactly covers this > scenario. I suggest to do the follwoing: > # run the general purpose testing job FLINK-8971 > # take a savepoint > # Modify the job by introducing a new operator and changing the order of > others > # Resume the modified job from the savepoint > # Verify that everything went correctly -- This message was sent by Atlassian JIRA (v7.6.3#76005)