[ https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457679#comment-16457679 ]
Rong Rong commented on FLINK-8690: ---------------------------------- Thanks for the suggestion [~fhueske]. I think this is much cleaner than having 2 logical plans since they are suppose to be "logical" LOL. I created the PR based on your suggestions and it looks pretty darn good covering all the cases (and potentially it also clears the way to support distinct group aggregation w/o time window in the future). Please take a look when you have time :-) > Update logical rule set to generate FlinkLogicalAggregate explicitly allow > distinct agg on DataStream > ----------------------------------------------------------------------------------------------------- > > Key: FLINK-8690 > URL: https://issues.apache.org/jira/browse/FLINK-8690 > Project: Flink > Issue Type: Sub-task > Reporter: Rong Rong > Assignee: Rong Rong > Priority: Major > > Currently, *FlinkLogicalAggregate / FlinkLogicalWindowAggregate* does not > allow distinct aggregate. > We are proposing to reuse distinct aggregate codegen work designed for > *FlinkLogicalOverAggregate*, to support unbounded distinct aggregation on > datastream as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)